Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add ignoreOrder option to avoid the OrderUndefinedError #166

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
extractedChunks.forEach(function(extractedChunk) {
if(extractedChunk.modules.length) {
extractedChunk.modules.sort(function(a, b) {
if(isInvalidOrder(a, b)) {
if(!options.ignoreOrder && isInvalidOrder(a, b)) {
compilation.errors.push(new OrderUndefinedError(a.getOriginalModule()));
compilation.errors.push(new OrderUndefinedError(b.getOriginalModule()));
}
Expand Down
4 changes: 4 additions & 0 deletions test/cases/order-undefined-error/a.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.a {
composes: c1 from './c1.css';
composes: c2 from './c2.css';
}
4 changes: 4 additions & 0 deletions test/cases/order-undefined-error/b.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.b {
composes: c2 from './c2.css';
composes: c1 from './c1.css';
}
2 changes: 2 additions & 0 deletions test/cases/order-undefined-error/c1.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.c1 {
}
2 changes: 2 additions & 0 deletions test/cases/order-undefined-error/c2.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.c2 {
}
8 changes: 8 additions & 0 deletions test/cases/order-undefined-error/expected/file.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
._3QiTkN7JPds2C9Bq73MpOX {
}
._3dtwYD12yqGZUJ-uPQLu9z {
}
._32HVXkGocfWZMaHoXEFkED {
}
.hbZI7DlQBB9VYNCgL20kL {
}
2 changes: 2 additions & 0 deletions test/cases/order-undefined-error/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
require('./a.css');
require('./b.css');
15 changes: 15 additions & 0 deletions test/cases/order-undefined-error/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
var ExtractTextPlugin = require("../../../");
module.exports = {
entry: "./index.js",
module: {
loaders: [{
test: /\.css$/,
loader: ExtractTextPlugin.extract('style', 'css?modules')
}]
},
plugins: [
new ExtractTextPlugin('file.css', {
ignoreOrder: true
})
]
}