chore: don't test webpack 5 on node 8 #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not a supported environment
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 10 10
Lines 479 479
Branches 161 161
=======================================
Hits 466 466
Misses 12 12
Partials 1 1 Continue to review full report at Codecov.
|
6 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Webpack 5 does not support node 8 and its test case does not run in that environment. This causes CI to fail as css-loader tries to run the test suite in node 8.
This PR skips running the webpack 5 test suite in node 8 so that future PRs can be green, per #1086 (comment).
Breaking Changes
n/a
Additional Info
n/a