-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: code #1059
refactor: code #1059
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 97.53% 97.17% -0.37%
==========================================
Files 10 10
Lines 447 460 +13
Branches 148 153 +5
==========================================
+ Hits 436 447 +11
- Misses 10 12 +2
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a common practice to follow the destructuring approach if the respective function receives a single argument which isn't used anywhere as a whole.
src/utils.js
Outdated
function getPreRequester(loaderContext) { | ||
const { loaders, loaderIndex } = loaderContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function getPreRequester(loaderContext) { | |
const { loaders, loaderIndex } = loaderContext; | |
function getPreRequester({ loaders, loaderIndex }) { |
This PR contains a:
Motivation / Use-Case
Just refactor, step #2
Breaking Changes
No
Additional Info
No