Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code #1059

Merged
merged 13 commits into from
Mar 25, 2020
Merged

refactor: code #1059

merged 13 commits into from
Mar 25, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Just refactor, step #2

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1059 into master will decrease coverage by 0.36%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   97.53%   97.17%   -0.37%     
==========================================
  Files          10       10              
  Lines         447      460      +13     
  Branches      148      153       +5     
==========================================
+ Hits          436      447      +11     
- Misses         10       12       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/plugins/postcss-url-parser.js 97.26% <66.66%> (-2.74%) ⬇️
src/index.js 100.00% <100.00%> (ø)
src/plugins/postcss-icss-parser.js 96.87% <100.00%> (+0.10%) ⬆️
src/plugins/postcss-import-parser.js 96.07% <100.00%> (+0.07%) ⬆️
src/utils.js 98.76% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b29b28...fa70fba. Read the comment docs.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a common practice to follow the destructuring approach if the respective function receives a single argument which isn't used anywhere as a whole.

src/utils.js Outdated
Comment on lines 181 to 182
function getPreRequester(loaderContext) {
const { loaders, loaderIndex } = loaderContext;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function getPreRequester(loaderContext) {
const { loaders, loaderIndex } = loaderContext;
function getPreRequester({ loaders, loaderIndex }) {

@alexander-akait alexander-akait merged commit 431f620 into master Mar 25, 2020
@alexander-akait alexander-akait deleted the refactor-code-2 branch March 25, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants