fix: do not duplicate css on composes
#1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 96.84% 98.14% +1.29%
==========================================
Files 10 10
Lines 476 484 +8
Branches 147 150 +3
==========================================
+ Hits 461 475 +14
+ Misses 12 8 -4
+ Partials 3 1 -2
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
issue-1037
branch
from
6a3f57f
to
48246b5
Compare
alexander-akait
force-pushed
the
issue-1037
branch
from
48246b5
to
777d876
Compare
|
thanks for all the hard work @evilebottnawi ! |
|
@jquense I will ping you when I done release, check if everything is well fixed |
fa93hws
reviewed
Jan 22, 2020
| @@ -22,15 +22,33 @@ module.exports = function(useSourceMap) { | |||
|
|
|||
| // import a list of modules into the list | |||
| // eslint-disable-next-line func-names | |||
| list.i = function(modules, mediaQuery) { | |||
| list.i = function(modules, mediaQuery, dedupe) { | |||
There was a problem hiding this comment.
Is that possible to have it to be true by default?
e.g.
function(modules, mediaQuery, dedupe = true)?
6 tasks
This was referenced Mar 21, 2020
This was referenced Apr 12, 2020
This was referenced Apr 24, 2020
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #1037
Breaking Changes
No
Additional Info
No