Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export defaultGetLocalIdent #1423

Merged
merged 1 commit into from
Mar 4, 2022
Merged

export defaultGetLocalIdent #1423

merged 1 commit into from
Mar 4, 2022

Conversation

SkReD
Copy link
Contributor

@SkReD SkReD commented Feb 21, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

#1422

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 21, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

alexander-akait
alexander-akait reviewed Feb 21, 2022
View reviewed changes
src/utils.js Outdated
@@ -324,7 +324,7 @@ function escapeLocalIdent(localident) {
);
}

function defaultGetLocalIdent(
export function defaultGetLocalIdent(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not export it here, we should reexport it from the entry point, i.e. index.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done here https://github.com/webpack-contrib/css-loader/pull/1423/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R30

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not export it from utils.js, we can rename file or move it to another places, just reexport it from index.js

Copy link
Contributor Author

@SkReD SkReD Mar 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i see. Will fix it soon

Copy link
Contributor Author

@SkReD SkReD Mar 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for review. Sorry for the previous mess

@codecov
Copy link

codecov bot commented Mar 1, 2022 •
edited
Loading

Codecov Report

Merging #1423 (2062917) into master (4dede55) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1130     1131    +1     
  Branches      411      411           
=======================================
+ Hits         1094     1095    +1     
  Misses         27       27           
  Partials        9        9
Impacted Files Coverage Δ
src/utils.js 94.72% <ø> (ø)
src/cjs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dede55...2062917. Read the comment docs.

@alexander-akait alexander-akait merged commit 207cf36 into webpack-contrib:master Mar 4, 2022
@cssecautomation cssecautomation mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkReD @alexander-akait