-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@font-face cause css-loader crash in 5.1.0 #1267
Comments
WIP |
Weird, can't reproduce, but I think it can be from postcss-loader (some plugin change internal AST, it is bad), I will try to fix by adding more checks |
6 tasks
Thanks! It's working properly with v5.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Don't crash
Actual Behavior
Code
The following rules will cause css-loader crash
The following rules will NOT cause css-loader crash
OR
How Do We Reproduce?
Create a font-face rule, use
/**/
comment between to url insrc
attributeThis will make
node.raws.value
to benull
at https://github.com/webpack-contrib/css-loader/pull/1264/files#diff-4a96d95d621a313e78a0a620a8763aaf8f975c2fcdf6feddd6d2db94314673e4R71so,
node.raws.value.raw
will causeTypeError: Cannot read property 'raw' of null
It should be
node.raws.value!= null
,not onlytypeof node.raws.value === "undefined"
@alexander-akait @cap-Bernardito
The text was updated successfully, but these errors were encountered: