Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types #276

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix: types #276

merged 1 commit into from
Dec 13, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 13, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix types for algorithm, algorithm should be defined if you provide custom options, because by default we are using ZlibOptions and they should be used only for gzip

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #276 (2af311b) into master (76009b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files           2        2           
  Lines         110      110           
  Branches       42       43    +1     
=======================================
  Hits          105      105           
  Misses          5        5           
Impacted Files Coverage Δ
src/index.js 95.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76009b7...2af311b. Read the comment docs.

@alexander-akait alexander-akait merged commit c5c3dba into master Dec 13, 2021
@alexander-akait alexander-akait deleted the fix-types-more branch December 13, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant