CoffeeScript 2

[jalavosus]

Basic changes to (hopefully) support coffeescript 2.

Essentially hoping that it doesn't require much besides requiring "coffeescript" instead of "coffee-script" and package.json requiring "coffeescript" at any version.

[jsf-clabot]

All committers have signed the CLA.

[michael-ciniawsky]

@jalavosus That one is actually a bit tricky, because the loader should support coffeescript v1x && v2x and folks are normally able to via peerDependencies, but since the package name changed it won't work

[michael-ciniawsky]

Maybe wrap in a try/catch ? 😛 I'm not sure...

[bebraw]

No need. Peer dep should force it. And it's better to fail hard in this case most likely.

[joshwiens]

@jalavosus - This is going to take some internal discussion on how we are going to handle this. Give us a day or two and we will get you sorted out one way or another.

[jalavosus]

I'll take a look into the try-catch option when I get back to my computer.

Can the package.json require both the old and new versions to be installed separately?

[michael-ciniawsky]

jashkenas/coffeescript#4462

[michael-ciniawsky]

@jalavosus It's safe to just go with coffeescript for v1. >= v1.8.x will be included in the new package and v2 is at coffeescript@beta atm. So please rebase and update to coffeescript 😛

[jalavosus]

If I read that right, this (ostensibly) means blindly using `coffeescript` is fine, yeah? On Mar 13, 2017 13:02, "Michael Ciniawsky" <[email protected]> wrote: jashkenas/coffeescript#4462 <jashkenas/coffeescript#4462> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3dsvm6EGZDDJwidvrBNzhHvkaPlCARks5rlXaugaJpZM4MRqca> .

[michael-ciniawsky]

@jalavosus I'm waiting for final confirmation in jashkenas/coffeescript#4462, but yes setting coffeescript as peerDependency and require('coffeescript') should be fine, no rush you can also wait for confirmation, if you don't want to spend effort on it without 😛

[bebraw]

The risk with this is that if they break their API in a major, the loader will break. So change to a range if you want to be careful.

[michael-ciniawsky]

Yep, we need to test for breaking Node API changes before release

{
  "peerDependencies": {
     "coffeescript": ">= 1.8.x"
   }
}

[michael-ciniawsky]

Closes #33

[michael-ciniawsky]

@jalavosus Please fix the peerDependency range and we are good to go

{
  "peerDependencies": {
     "coffeescript": ">= 1.8.x || >= 2.x"
   }
}

[jalavosus]

Updated package.json, sorry for the holdup.

[michael-ciniawsky]

@jalavosus Thx