-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for interfaces implementing interfaces #740
Commits on Nov 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aa4f719 - Browse repository at this point
Copy the full SHA aa4f719View commit details -
Implement tests for interfaces implementing interfaces
This ports the JavaScript tests for `RFC: Allow interfaces to implement other interfaces` to PHP. This should ensure that there is sufficient test coverage for the changes made to support interfaces implementing interfaces. Tests taken from https://github.com/graphql/graphql-js/pull/2084/files including any typoes in test description strings to aid in comparison.
Configuration menu - View commit details
-
Copy full SHA for 39c2fb6 - Browse repository at this point
Copy the full SHA 39c2fb6View commit details -
Fix extend implement interface in Parser
This is part of the update to allow interfaces to implement interfaces. A single extend statement to add an implementation of an interface without field declarations is valid. This was caught by tests and brings in a change from graphql/graphql-js#2084
Configuration menu - View commit details
-
Copy full SHA for 951d882 - Browse repository at this point
Copy the full SHA 951d882View commit details -
Validate interface implemented ancestors
Part of the work done to implement interfaces implementing interfaces. This was caught by test and improves on the previously done changes for the SchemaValidationContext by implementing `validateTypeImplementsAncestors` which was missing.
Configuration menu - View commit details
-
Copy full SHA for d525145 - Browse repository at this point
Copy the full SHA d525145View commit details
Commits on Nov 30, 2020
-
Properly apply Schema changes for interface extension support
This redoes the work done for the Schema class since it was previously guessed at. It now more closely follows graphql/graphql-js/pull/2084
Configuration menu - View commit details
-
Copy full SHA for a8f94b6 - Browse repository at this point
Copy the full SHA a8f94b6View commit details -
Improve interface extension related typehints
Co-authored-by: Benedikt Franke <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da07108 - Browse repository at this point
Copy the full SHA da07108View commit details
Commits on Dec 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for dc34eae - Browse repository at this point
Copy the full SHA dc34eaeView commit details -
Merge branch 'master' into kingdutch-master
# Conflicts: # src/Utils/SchemaPrinter.php
Configuration menu - View commit details
-
Copy full SHA for ee3bc56 - Browse repository at this point
Copy the full SHA ee3bc56View commit details
Commits on Dec 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 602bf4e - Browse repository at this point
Copy the full SHA 602bf4eView commit details
Commits on Jan 23, 2021
-
Don't remove but deprecate DANGEROUS_CHANGE_IMPLEMENTED_INTERFACE_ADDED
Removing a public constant is a breaking change and can not be implemented in a minor version. Instead the internal value is changed to ensure that existing code keeps working with the new interface implementation logic.
Configuration menu - View commit details
-
Copy full SHA for 9ed1d9d - Browse repository at this point
Copy the full SHA 9ed1d9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f2a1e4 - Browse repository at this point
Copy the full SHA 1f2a1e4View commit details