Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse moxy dependency needed? #24

Open
reckart opened this issue Dec 22, 2020 · 1 comment
Open

Eclipse moxy dependency needed? #24

reckart opened this issue Dec 22, 2020 · 1 comment

Comments

@reckart
Copy link

reckart commented Dec 22, 2020

Is the Eclipse moxy dependency really needed?

I searched the repo for "eclipse" on github, and it appears that it might be used only for an annotation (org.eclipse.persistence.oxm.annotations.XmlValueExtension) which really seems not to be used anywhere.
@emanueldima
Copy link
Member

This dependency was added by @pkolb in #17, for compatibility with the EclipseLink MOXy JAXB implementation. I see that it is used in two places: https://github.com/weblicht/wlfxb/search?q=XmlValueExtension&type=code. I'm not sure, but the documentation seems to specify it's used for compatibility with versions of EclipseLink before 2.5.x, so we may be able to drop it in a subsequent release. @pkolb, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emanueldima @reckart