Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CLI to be run without .sonarwhalrc in current directory #718

Closed
poshaughnessy opened this issue Dec 15, 2017 · 6 comments
Closed

Allow CLI to be run without .sonarwhalrc in current directory #718

poshaughnessy opened this issue Dec 15, 2017 · 6 comments
Assignees
Labels

Comments

@poshaughnessy
Copy link
Contributor

poshaughnessy commented Dec 15, 2017

Proposal: Given that the recommended use of the CLI is to point to a URL (rather than a local project), I would suggest we do not need to pollute the current directory with a .sonarwhalrc file.

How about...

  1. If no .sonarwhalrc found in the current directory, look for .sonarwhalrc in user's home directory.
  2. If no .sonarwhalrc found in user's home directory either, proceed with default configuration? (With an appropriate warning / note?). This would have the added benefit of reducing a necessary step (sonarwhal init) for first time users to try out the CLI.

(This may be related to #713?)

@alrra alrra added the area:cli label Dec 15, 2017
@alrra
Copy link
Contributor

alrra commented Dec 15, 2017

I would suggest we do not need to pollute the current directory with a .sonarwhalrc file.

If no .sonarwhalrc found in the current directory, look for .sonarwhalrc in user's home directory.

I personally agree that we should do that.

(I don't remember why we didn't do it that way in the first place 🤔)

If no .sonarwhalrc found in user's home directory either, proceed with default configuration? (With an appropriate warning / note?).

As long as we make it clear (with an appropriate warning/note as you specified), I'm personally ok with it.


@sonarwhal/core Thoughts?

@alrra
Copy link
Contributor

alrra commented Jan 8, 2018

@poshaughnessy, @diekus, @torgo

I was discussing this issue with @molant, and we think this can be a good first issue to solve that will also allow you to better understand how sonarwhal works.

Do any of you want to take this issue? We can help you along the way!

@poshaughnessy
Copy link
Contributor Author

@alrra Sorry for the delay. If it's not too late, yes, let's give this a try! I'll see how far I get and hopefully can put in an initial PR for review and feedback :)

@alrra
Copy link
Contributor

alrra commented Jan 22, 2018

If it's not too late, yes, let's give this a try!

Go for it, and don't hesitate to let us know if we can help!

@molant
Copy link
Member

molant commented Feb 21, 2018

@poshaughnessy we've separated everything into packages now so if you want to give this a try let us know. Otherwise we will probably take care of this in the next few days.
There have been some changes in the projects structure so make sure to check the contributor guide (PR for those changes is #827 in case @alrra doesn't get to merge it before you read this).

@alrra
Copy link
Contributor

alrra commented Mar 8, 2018

Note: @molant opened #863 to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants