Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to cloudinary rule #658

Open
molant opened this issue Nov 15, 2017 · 2 comments
Open

Improvements to cloudinary rule #658

molant opened this issue Nov 15, 2017 · 2 comments

Comments

@molant
Copy link
Member

molant commented Nov 15, 2017

There is a new endpoint from Cloudinary where you can upload an image and it will give you information about other formats. It is currently not supported in the npm package but it's available in one of the branches. We should look into adding support for it.

Because we only need to upload images maybe we can remove the dependency on the package and have our own version.

I'll update this issue once I've explored a bit more the code.

@AndrewCraswell
Copy link

Do you have a link to this? I was already thinking about building a desktop tool to "scan" images by just uploading them to Cloudinary and downloading the optimized version, but this sounds more interesting. Would love to have similar functionality built into Sonarwhal...

@molant
Copy link
Member Author

molant commented Dec 11, 2017

The new endpoints are exposed in https://github.com/cloudinary/cloudinary_npm/tree/analyze_api and used in https://github.com/cloudinary/web-speed-test-client (code for https://webspeedtest.cloudinary.com/). The code hasn't been published to npm so we will probably have to create our own uploader that talks with the endpoint directly (shouldn't have to be too complicated)

My plan is to start working on this in January (trying to finish #142 and #12 and some other items) but if you want to submit a PR before that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants