Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom event to evaluate scripts on a connector #497

Closed
molant opened this issue Sep 7, 2017 · 2 comments
Closed

Custom event to evaluate scripts on a connector #497

molant opened this issue Sep 7, 2017 · 2 comments

Comments

@molant
Copy link
Member

molant commented Sep 7, 2017

Initial comment: #494 (comment)

Right now we are telling developers to use traverse::end to evaluate their scripts. The problem is that with the changes in #494 with jsdom we could actually evaluate at the beginning instead of waiting at the end to save a few seconds. That is not the case with chrome where we will be interfering with the page.

The proposal is to create a new event canevaluate (or similar) that will be fired by the connectors when it is best for them to evaluate. jsdom will fire it sooner than chrome in this case.

What do you think @sonarwhal/contributors ?

@molant
Copy link
Member Author

molant commented Aug 8, 2018

@alrra we did this, right?

@alrra
Copy link
Contributor

alrra commented Aug 8, 2018

we did this, right?

Yes, in 32bddebdb212.

@alrra alrra closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants