Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Preload LINK elements to locally hosted resources making use of BASE element not recognized by scanner #3946

Open
tmb-github opened this issue Aug 13, 2020 · 1 comment
Open

[Bug] Preload LINK elements to locally hosted resources making use of BASE element not recognized by scanner #3946

tmb-github opened this issue Aug 13, 2020 · 1 comment
Assignees
@antross
Labels
msft-consider Issues being considered for contributions from Microsoft priority:medium type:bug

Comments

@tmb-github
Copy link

tmb-github commented Aug 13, 2020 •
edited
Loading

Windows 8.1
Chrome Version 84.0.4147.125 (Official Build) (64-bit)
Webhint online scanner running Webhint version 6.0.7
Website scanned; https://thomasbrodhead.com

Preload elements referencing locally hosted resources that make use of the <base> path element are not recognized. For example:

hint #1: Could not be fetched.

https://thomasbrodhead … Cabin-Bold-700.woff2

<link rel="preload" href="fonts/Cabin-Bold-700.woff2" as="font" type="font/woff2" crossorigin="anonymous">

10 hints are triggered for locally hosted font resources. The common denominator is that they make use of the element in the <head>:

<base href="https://thomasbrodhead.com/">
@tmb-github tmb-github changed the title [Bug] Bug description [Bug] Preload LINK elements to locally hosted resources making use of BASE element not recognized by scanner Aug 13, 2020
@antross
Copy link
Member

antross commented Aug 17, 2020

Thanks for another good report @tmb-github!

Looks like this is only affecting @hint/hint-http-compression so it should repro on the webhint CLI as well (but not the browser extension which excludes this hint due to API limitations). Unlike most hints this one tries to manually re-request resources using a variety of different headers to test server configuration. I haven't had a chance to dig deeper yet so I'm not sure if it's specifically a problem with the <base> element (which seems likely), but will share once I know more.

@antross antross added the msft-consider Issues being considered for contributions from Microsoft label Aug 20, 2020
@antross antross self-assigned this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

Labels
msft-consider Issues being considered for contributions from Microsoft priority:medium type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antross @tmb-github