Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all event interfaces implement another interface? #155

Closed
molant opened this issue Apr 20, 2017 · 4 comments
Closed

Make all event interfaces implement another interface? #155

molant opened this issue Apr 20, 2017 · 4 comments
Assignees

Comments

@molant
Copy link
Member

molant commented Apr 20, 2017

So far all interface events have the resource property and we are required to have it because of this.

I just had a problem where I created a new event and forgot to add that property so I'm thinking that we should do something like:

export interface ISonarEvent {
  resource: string;
// any other common things in here
}

export interface IRandomEvent implements ISonarEvent {
// stuff here
}

That way if we need to change some common stuff is easier and forgetting them more complicated.

@alrra, @sarvaje thoughts?

@alrra
Copy link
Contributor

alrra commented Apr 21, 2017

I'm thinking that we should do something like:

👍

ISonarEvent

ICollectorEvent?

@sarvaje
Copy link
Contributor

sarvaje commented Apr 21, 2017

I like the idea

@molant
Copy link
Member Author

molant commented Jun 21, 2017

@sarvaje I think you are taking care of this in #76 so I'm assigning it to you.

@sarvaje
Copy link
Contributor

sarvaje commented Jun 27, 2017

This is fixed in 65528ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants