-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows association flags to WGPUSurfaceDescriptorFromWindowsHWND #298
Comments
Jun 6 meeting:
|
I have slight concerns with adding the flags directly in this descriptor because it is only useful on the D3D11 and D3D12 backend, but the HWND descriptor can also be used to Vulkan and OpenGL/ES, so the flags would do nothing there. At the minimum we'll need docs to cover that. |
We hadn't considered HWND on Vulkan / GL - do you think this would be better as an independent feature? I think if the feature isn't enabled, you'd get a validation error during surface.Configure(..) |
I guess if MakeWindowAssociation gets called in Configure we could make this an extension to Configure? |
Moving to an extension to Configure sounds fine to me. @SoapyMan would you like to champion adding this since it seems important for your use case? |
Sounds good to me |
This has a resolution but it should be implemented before we try to standardize it. It's going to be an extension struct anyway so it's |
This PR google/dawn#16 adds DXGI_MWA_NO_ALT_ENTER always to Dawn.
Probably the better thing would be for an application to be able to configure the window association when creating the WGPUSurface.
Concretely, something like:
typedef struct WGPUSurfaceDescriptorFromWindowsHWND { WGPUChainedStruct chain; void * hinstance; void * hwnd; + uint32_t windowAssocationFlags; } WGPUSurfaceDescriptorFromWindowsHWND WGPU_STRUCTURE_ATTRIBUTE;
For reference, valid flags are:
The text was updated successfully, but these errors were encountered: