fix(meeting): updated sdkcomponentadapter version to add password flow #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreenara
approved these changes
May 8, 2024
@sreenara I disabled the video that's why |
arun3528
pushed a commit
that referenced
this pull request
May 8, 2024
|
🎉 This PR is included in version 1.26.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -115,7 +115,7 @@ | |||
| "plugins": [ | |||
| "@babel/plugin-proposal-export-default-from", | |||
| "@babel/plugin-proposal-nullish-coalescing-operator", | |||
| "@babel/plugin-proposal-object-rest-spread", | |||
| "@babel/plugin-transform-object-rest-spread", | |||
There was a problem hiding this comment.
I just see PR is merged, @Kesari3008 , One question, why is this change in line -
This "@babel/plugin-proposal-object-rest-spread", is replaced by "@babel/plugin-transform-object-rest-spread",
|
@Kesari3008, Also I don't see package.lock file change ? Did you do npm install after upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading sdk-component-adpater repo version to the latest to include the password flow for the guest user.
Testcase 1: The guest joins the meeting by entering the password.
Testcase 2: The guest joins the meeting as host by entering the host key
Screen.Recording.2024-05-08.at.3.08.41.PM.mp4
Testcase 3: Host joins with host access token without a password prompt.
https://github.com/webex/widgets/assets/65543166/135cf872-4e0c-43e1-a0ec-3317c45ac45d