Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle invalid m-line with trailing whitespace #67

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: handle invalid m-line with trailing whitespace #67

merged 1 commit into from
Dec 12, 2023

Conversation

brycetham
Copy link
Contributor

This PR fixes the case in which an invalid m-line with a trailing whitespace may be considered to be valid. For example, "m=video 9 UDP/TLS/RTP/SAVPF " should be throwing an error, but the trailing space causes webrtc-core to think it is valid.

bbaldino
bbaldino approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@bbaldino bbaldino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@brycetham brycetham merged commit 6f4fbdb into main Dec 12, 2023
1 check passed
@brycetham brycetham deleted the btham/invalid_mline_trailing_space branch December 12, 2023 17:56
bbaldino pushed a commit that referenced this pull request Dec 12, 2023
@semantic-release-bot
chore(release): 2.2.3 [skip ci]
8f644fd 
## [2.2.3](v2.2.2...v2.2.3) (2023-12-12)

### Bug Fixes

* handle invalid m-line with trailing whitespace ([#67](#67)) ([6f4fbdb](6f4fbdb))
* rename error type enum ([#66](#66)) ([cc3473b](cc3473b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbaldino bbaldino bbaldino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycetham @bbaldino