feat: add id, readyState, and getAllEffects to stream classes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Sep 29, 2023
src/media/stream.ts
Outdated
| @@ -14,6 +15,8 @@ interface StreamEvents { | |||
| * Base stream class. | |||
| */ | |||
| abstract class _Stream { | |||
| readonly id = uuid(); | |||
There was a problem hiding this comment.
Is there a reason not to use MediaStream::id?
There was a problem hiding this comment.
I thought originally that maybe outputStream would change, but I see now that we had explicitly made it so that the stream itself would always remain the same, so yeah I think I can change the id getter to return this.outputStream.id.
brycetham
changed the title
bbaldino
approved these changes
Oct 2, 2023
bbaldino
pushed a commit
that referenced
this pull request
Oct 2, 2023
# [2.2.0](v2.1.0...v2.2.0) (2023-10-02) ### Features * add id, readyState, and getAllEffects to stream classes ([#62](#62)) ([62deb74](62deb74))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
idgetter to theStreamclass, as well as areadyStategetter and agetAllEffectsmethod to theLocalStreamclass.