feat: add generics to device management #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycetham
commented
Jul 28, 2023
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| type Constructor<T> = new (...args: any[]) => T; | ||
|
|
||
| /** | ||
| * Represents a WCME error, which contains error type and error message. |
There was a problem hiding this comment.
We can do this in a later PR, but I think it's kind of weird that we're referencing WCME here, and naming the error class WcmeError, especially since WCME doesn't actually call any of the device management APIs.
arun3528
approved these changes
Jul 28, 2023
| let stream: MediaStream; | ||
| try { | ||
| stream = await media.getUserMedia({ audio: { ...constraints } }); | ||
| } catch (error) { | ||
| throw new WcmeError( | ||
| ErrorTypes.CREATE_MICROPHONE_STREAM_FAILED, | ||
| `Failed to create microphone stream ${error}` | ||
| ErrorTypes.CREATE_STREAM_FAILED, |
There was a problem hiding this comment.
Not now but would be nicer to have error codes associated later , so that we know what the cause of failure else anyone using this lib need to figureout what does all getuser media error corresponds to
| >( | ||
| cameraStreamConstructor: Constructor<T>, | ||
| microphoneStreamConstructor: Constructor<U>, | ||
| constraints?: { video?: VideoDeviceConstraints; audio?: AudioDeviceConstraints } |
bbaldino
pushed a commit
that referenced
this pull request
Jul 28, 2023
# [2.1.0](v2.0.0...v2.1.0) (2023-07-28) ### Features * add generics to device management ([#61](#61)) ([adf048e](adf048e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generics to device management
create*Streamfunctions in order to support using custom stream classes in these methods. It also adds a new API,createCameraAndMicrophoneStreams, to create both a camera stream and a microphone stream with a singlegetUserMediacall.As part of this change, I've also slightly modified the
ErrorTypesto have a genericCREATE_STREAM_FAILEDerror so it can be used in all cases in whichgetUserMediaorgetDisplayMediafail.This completes SPARK-448441 and SPARK-448443.