feat: limit appliable constraints #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Jun 30, 2023
| // track itself. This would not include 'deviceId', and maybe more of these values. | ||
| // Might need to define one AudioConstraints for use with getUserMedia, and refine | ||
| // it even further for applyConstraints here. | ||
| export type AudioConstraints = Pick< |
There was a problem hiding this comment.
Do we have these defined somewhere? The 'full set' should be usable in the getUserMedia calls
There was a problem hiding this comment.
We do have AudioDeviceConstraints and VideoDeviceConstraints defined in device-management.ts, if that's what you're asking.
There was a problem hiding this comment.
Unrelated, but just noticed that we're not picking from MediaTrackConstraints when defining VideoDeviceConstraints like we do with AudioDeviceConstraints. I can make that change real fast.
brycetham
force-pushed
the
btham/appliable_constraints
branch
from
3705b4b
to
f30c6ce
Compare
bbaldino
approved these changes
Jun 30, 2023
brycetham
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: new stream classes initial commit (#49) * feat: new stream classes initial commit * refactor: originStream -> inputStream * feat: integrate new stream types (#50) * feat: replace LocalMicrophoneTrack with LocalMicrophoneStream * refactor: replace LocalDisplayTrack with LocalDisplayStream * refactor: replace LocalCameraTrack with LocalCameraStream * refactor: remove LocalTrack * refactor: rename originTrack -> inputTrack * feat: effects api (#52) * feat: add effects api * fix: add loadingeffects protection * test: localstream unit tests * chore: upgrade effects version * refactor: add methods and update events for stream classes (#55) * refactor: add support for wcme refactor * chore: minor updates to LocalStream and unit tests --------- Co-authored-by: Bryce Tham <[email protected]> * feat: limit appliable constraints (#56) * feat: limit appliable constraints * refactor: pick VideoDeviceConstraints from MediaTrackConstraints --------- Co-authored-by: Bryce Tham <[email protected]> * feat: listen to track events and additional updates to stream classes (#57) * feat: listen to track events and additional updates to stream classes * fix: preserve outputStream in changeOutputTrack * chore: change outputStream to readonly * chore: update unit tests and comments --------- Co-authored-by: Bryce Tham <[email protected]> * chore: update docs and errors in device management API * fix: stop outputTrack on LocalStream stop --------- Co-authored-by: bbaldino <[email protected]> Co-authored-by: Tyler McCarthy <[email protected]> Co-authored-by: Bryce Tham <[email protected]>
brycetham
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: new stream classes initial commit (#49) * feat: new stream classes initial commit * refactor: originStream -> inputStream * feat: integrate new stream types (#50) * feat: replace LocalMicrophoneTrack with LocalMicrophoneStream * refactor: replace LocalDisplayTrack with LocalDisplayStream * refactor: replace LocalCameraTrack with LocalCameraStream * refactor: remove LocalTrack * refactor: rename originTrack -> inputTrack * feat: effects api (#52) * feat: add effects api * fix: add loadingeffects protection * test: localstream unit tests * chore: upgrade effects version * refactor: add methods and update events for stream classes (#55) * refactor: add support for wcme refactor * chore: minor updates to LocalStream and unit tests --------- Co-authored-by: Bryce Tham <[email protected]> * feat: limit appliable constraints (#56) * feat: limit appliable constraints * refactor: pick VideoDeviceConstraints from MediaTrackConstraints --------- Co-authored-by: Bryce Tham <[email protected]> * feat: listen to track events and additional updates to stream classes (#57) * feat: listen to track events and additional updates to stream classes * fix: preserve outputStream in changeOutputTrack * chore: change outputStream to readonly * chore: update unit tests and comments --------- Co-authored-by: Bryce Tham <[email protected]> * chore: update docs and errors in device management API * fix: stop outputTrack on LocalStream stop --------- Co-authored-by: bbaldino <[email protected]> Co-authored-by: Tyler McCarthy <[email protected]> Co-authored-by: Bryce Tham <[email protected]> BREAKING CHANGE: convert track-based classes into stream-based classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the constraints that can be passed to the
applyConstraintsmethod in bothLocalAudioStreamandLocalVideoStream.