fix: resolve system audio as null if unavailable #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
approved these changes
Jun 2, 2023
bbaldino
pushed a commit
that referenced
this pull request
Jun 2, 2023
## [1.7.1](v1.7.0...v1.7.1) (2023-06-02) ### Bug Fixes * resolve system audio as null if unavailable ([#54](#54)) ([c90617b](c90617b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
createDisplayTrackWithAudioto resolve the audio track asnullif it is not available (i.e. the user unchecks the share audio option when selecting content to share in Chrome). This fix is necessary becauseLocalTrackexpects at least one track to exist in the media stream when created.