Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made create*Track() functions generic #38

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

marcin-bazyl
Copy link
Collaborator

To allow JS-SDK to have classes that extend webrtc-core LocalMicrophoneTrack, LocalCameraTrack etc.

Copy link
Collaborator

@bbaldino bbaldino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. note that i expect these, to some extent, to be temporary changes. i have a writeup on some thoughts of how to improve the design in webrtc-core here

@marcin-bazyl marcin-bazyl merged commit 5493d89 into main Mar 27, 2023
github-actions bot pushed a commit that referenced this pull request Mar 27, 2023
## [1.4.1](v1.4.0...v1.4.1) (2023-03-27)

### Bug Fixes

* made create*Track() functions generic ([#38](#38)) ([5493d89](5493d89))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants