Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Method named getNumActiveSimulcastLayers & event to LocalTrack for constraints changed #35

Merged
merged 3 commits into from
Mar 4, 2023

Conversation

x-epoch
Copy link
Contributor

@x-epoch x-epoch commented Mar 3, 2023

This code changes merged the PR of Bryce's support applying music mode constraints
Mainly changes:

  1. Add an event to LocalTrack for when the constraints are called
  2. Add a method named getNumActiveSimulcastLayers to check the resolution and return how many layers will be active

@bbaldino
Copy link
Collaborator

bbaldino commented Mar 3, 2023

please separate out bryce's changes to their own PR

@x-epoch
Copy link
Contributor Author

x-epoch commented Mar 4, 2023

please separate out bryce's changes to their own PR

Do you mean we can merge Bryce's PR firstly ? Since this code changes depends on 'applyConstraints' which contains in Bryce's PR.

@bbaldino bbaldino merged commit 9298169 into webex:main Mar 4, 2023
github-actions bot pushed a commit that referenced this pull request Mar 6, 2023
# [1.4.0](v1.3.0...v1.4.0) (2023-03-06)

### Bug Fixes

* update disposeEffects doc ([fa6d58b](fa6d58b))

### Features

* Method named getNumActiveSimulcastLayers & event to LocalTrack for constraints changed ([#35](#35)) ([9298169](9298169))
* support applying music mode constraints ([#27](#27)) ([081b8b2](081b8b2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants