feat: add the api for fetching the connection type #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Dec 19, 2022
src/peer-connection.ts
Outdated
| * | ||
| * @returns The connection type which would be {Promise<'UDP' | 'TCP' | 'TURN-TLS' | 'TURN-TCP' | 'TURN-UDP' | 'unknown'>}. | ||
| */ | ||
| async getCurrentConnectionType(): Promise<string> { |
There was a problem hiding this comment.
Wondering if it's worth explicitly defining a type for these: instead of string, doing something like:
const ConnectionType = 'UDP' | 'TCP' | 'TURN-TLS' | 'TURN-TCP' | 'TURN-UDP' | 'unknown';
There was a problem hiding this comment.
Good suggestion, I have already updated this code .
marcin-bazyl
approved these changes
Dec 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [1.3.0](v1.2.0...v1.3.0) (2022-12-20) ### Features * add the api for fetching the connection type ([#20](#20)) ([4e5fe55](4e5fe55))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for fetching the the connection type, which would return the type of Promise<'UDP' | 'TCP' | 'TURN-TLS' | 'TURN-TCP' | 'TURN-UDP' | 'unknown'>.
Details can refer to https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-379327