fix: update meeting name after fetch meetinginfo #342
Conversation
src/MeetingsSDKAdapter.js
Outdated
| @@ -595,9 +595,11 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter { | |||
| )), | |||
| tap((meeting) => { | |||
| const sdkMeeting = this.fetchMeeting(meeting.ID); | |||
| const updatedTitle = sdkMeeting.meetingInfo.topic || meeting.title; | |||
| const updatedMeeting = {...meeting, title: updatedTitle}; | |||
There was a problem hiding this comment.
Did we try updating the meeting object itself here with updated title instead of creating new object?
src/MeetingsSDKAdapter.test.js
Outdated
| @@ -450,6 +450,40 @@ describe('Meetings SDK Adapter', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should emit EVENT_MEETING_UPDATED with the updated title from sdkMeeting.meetingInfo.topic', (done) => { | |||
| // Mock implementations | |||
| meetingsSDKAdapter.fetchMeetingTitle = jest.fn(() => Promise.resolve('my meeting')); | |||
There was a problem hiding this comment.
Why do we need this mock as I can the mock needed is the one with meetingInfo.topic?
src/MeetingsSDKAdapter.js
Outdated
| this.meetings[meeting.ID] = meeting; | ||
| sdkMeeting.emit(EVENT_MEETING_UPDATED, meeting); | ||
| this.meetings[meeting.ID] = updatedMeeting; | ||
| sdkMeeting.emit(EVENT_MEETING_UPDATED, updatedMeeting); |
There was a problem hiding this comment.
Did we test all the scenarios of joining the meeting and confirmed that the title appears in all the cases correctly?
There was a problem hiding this comment.
yes, attached screenshots
src/MeetingsSDKAdapter.js
Outdated
| @@ -634,6 +637,13 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter { | |||
| try { | |||
| const sdkMeeting = this.fetchMeeting(ID); | |||
|
|
|||
| // eslint-disable-next-line no-console | |||
| console.log('ravi joinMeeting sdkMeeting ', sdkMeeting); | |||
There was a problem hiding this comment.
Please remove this console logs before merge
| @@ -661,6 +671,10 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter { | |||
| }), | |||
| })); | |||
| } else { | |||
| // update the meeting title if available after password verification | |||
There was a problem hiding this comment.
Why did we need this code and above now?
## [1.112.11](v1.112.10...v1.112.11) (2024-10-10) ### Bug Fixes * update meeting name after fetch meetinginfo ([#342](#342)) ([20a46f8](20a46f8))
|
🎉 This PR is included in version 1.112.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue: Meeting name not showing in meeting widget instead it shows sip address.
Fix: added update title code in fetchMeetingInfo.topic
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-566707
