Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ShadyDOM settings via ShadyDOM object and URL flags are incompatible. #250

Open
sorvell opened this issue Jan 22, 2020 · 2 comments

Comments

@sorvell
Copy link
Collaborator

sorvell commented Jan 22, 2020

Loading the polyfill bundle with URL flags is not compatible with using the object syntax to force ShadyDOM on.

In particular, if you do ShadyDOM = {force: true, noPatch: true} and then load the page with ?wc-shadydom=true then noPatch is set to off because it's read off the URL in this case. It should fall back to its current value.

@sorvell sorvell self-assigned this Jan 22, 2020
sorvell pushed a commit to Polymer/polymer that referenced this issue Jan 22, 2020
* querySelectorAll now polyfills an NodeList so coerce to Array when doing `deepEquals`
* when testing noPatch, add workaround for webcomponents/polyfills#250.
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants