This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Feature check broken Webkit setters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitting tests against web-platform-tests will have the chance of it trickling into WebKit at some point (and other browsers) so there would definitely be a good idea. |
|
Change looks good. @azakus Does Polymer still pull this in? |
dfreedm
added a commit
that referenced
this pull request
Jan 9, 2015
Feature check broken Webkit setters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into a bug with Webkit URL setters. It doesn't seem to handle entity encodings correctly.
Reported at https://bugs.webkit.org/show_bug.cgi?id=140174
Do you think this is something this polyfill should work around and force into a "broken url" state?
Also, I'm wondering where the best place to submit tests for this is? Here or https://github.com/w3c/web-platform-tests/tree/master/url?
cc @arv @annevk