Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Reorganize tests #57

Open
guruvamsi-policharla opened this issue Jan 10, 2024 · 0 comments
Open

[TASK] Reorganize tests #57

guruvamsi-policharla opened this issue Jan 10, 2024 · 0 comments
Labels
p3 🔵 Issues should be resolved eventually

Comments

@guruvamsi-policharla
Copy link
Contributor

The tests could be organized better. Currently, we have them spread across dist-primitives/examples and individual modules such as dist-primitives/dfft/tests.rs. This was an artifact of the original zksaas repo needing a shell script to enable networking.

Given that we are no longer constrained by this, we can place all of the tests within individual modules -- dfft/dmsm/dpp and get rid of dist-primitives/examples entirely.

Also, dist-primitives/examples/dfft_test.rs is redundant in light of the more extensive set of tests in dist-primitives/dfft/tests.rs.
@guruvamsi-policharla guruvamsi-policharla added the p3 🔵 Issues should be resolved eventually label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 🔵 Issues should be resolved eventually
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guruvamsi-policharla