You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 8, 2021. It is now read-only.
Right now this xrpackage respository is doing far too many things.
This was useful during the experimentation phase (for convenience), but the monolithic nature of this repository is making it hard for contributors to onboard.
Here are some of the independent pieces in this repo:
Note that the xrpackage-cli repo is already completely separate from this one; the CLI is still kind of monolithic but nowhere near to the degree of this repository, since it does a lot less.
I wouldn't advocate for splitting this functionality into 10 repositories right now but there are some clear contenders of things that should be separate. For example, the core API (xrpackage.js) and the frontend site pages for xrpackage.org (index.html, browse.html, etc.) should probably not be in the same repo.
Opening this issue to get the discussion started for the right path forward.
The text was updated successfully, but these errors were encountered:
Moving the HTML site to be separate from the core might be a good start (index.html, edit.html, run.html, browse.html, inspect.html, and dependencies).
If we do that then probably static.xrpackage.org could be this repo, while xrpackage.org becomes the frontend site extracted out.
Some urls might need to be updated in that case, since many repositories are for example dynamically loading https://xrpackage.org/xrpackage.js on the frontend.
Right now this
xrpackage
respository is doing far too many things.This was useful during the experimentation phase (for convenience), but the monolithic nature of this repository is making it hard for contributors to onboard.
Here are some of the independent pieces in this repo:
XRPackageEngine
runtime for running the render loop for package renderingXRPackage
api for parsing packages and adding them toXRPackageEngine
xrpackage.org
: Inspect page, Run page, Edit page, Browse pagexrpackage/xrpackage.js
Line 1068 in f73ef69
xrpackage.org
page that is opened by the CLI tool: https://github.com/webaverse/xrpackage/blob/master/bake.html)Note that the
xrpackage-cli
repo is already completely separate from this one; the CLI is still kind of monolithic but nowhere near to the degree of this repository, since it does a lot less.I wouldn't advocate for splitting this functionality into 10 repositories right now but there are some clear contenders of things that should be separate. For example, the core API (
xrpackage.js
) and the frontend site pages forxrpackage.org
(index.html
,browse.html
, etc.) should probably not be in the same repo.Opening this issue to get the discussion started for the right path forward.
The text was updated successfully, but these errors were encountered: