You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good catch @andreyrd ! Yes please open a PR, start from the dev branch creating a new one for example feature -data-arnft or name it as you prefer.
Also the terminate worker function need to be improved, actually i think can't terminate a single worker.
I'll try to get it soon.
I think this method needs to be aware of the global config, and use that to determine if the container was created. Because the user may have also specified an id other than app for the container.
Calling
ARnft.dispose()
will remove the #app element even if it was not created by ARnft:CameraViewRenderer.ts:230
This is a problem for a Vue app, since it ends up destroying the entire app.
What if you add a special
data-arnft
attribute to app when creating it in Container.ts, and if that does not exist, you don't remove the element.I can open a PR if that makes sense.
The text was updated successfully, but these errors were encountered: