-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to find the space when a user PUTs a CAR #95
Comments
The proposal that @Gozala re-shared is to write the Alternatives are
|
or we could add global secondary index on the the store/add table to let us find spaces by car. { partitionKey: 'link', sortKey: 'space' } |
adds an index to the store table using link as the partition key as a possible fix for #95 to let us find all the records for a given CAR CID. TODO - [ ] add method to store so we can query by link - [ ] add tests License: MIT Signed-off-by: Oli Evans <[email protected]>
We will want to be able to show when a store/add is pending vs we have actually got the CAR.
The store/add dynamo table is currently partitioned by space DID, and the car CID is the sort key, so we enforce a unique car per space. This makes it cheap to find all cars for a space and terrible for finding a space by car CID.
We need some way to connect the ObjectCreated event we get from S3 back to the store/add invocation that enabled it.
Of note, we will need to handle the case where multiple independent store/add invocations are made for the same shard cid. We only skip providing a presigned url once an upload is fully written to s3. multiple callers could start writing at the same time.
The text was updated successfully, but these errors were encountered: