Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #173 and Fixes #172. It targets #185 as it relies on changes there.
In the other PR @alanshaw had this suggestion
And this PR still does not add
fromJSON
because, even though it will serialize the whole chain into a JSON which could be then de-serialized into compatible chain there is still a problem with the fact thatfromJSON
would not know if inline proofs do match claimed CIDs. This means that motivated attacker could use this an a attack vector.In other words code that imports delegation should also validate hashes which is async operation and there for does not fit into a
fromJSON
signature.That said I think it still useful to have
toJSON
method for debugging purposes, which is what this PR adds.