Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Magento client #8

Closed
evghen1 opened this issue May 23, 2024 · 3 comments
Closed

Cache Magento client #8

evghen1 opened this issue May 23, 2024 · 3 comments
Assignees
@ca7alindev
Labels
enhancement New feature or request

Comments

@evghen1
Copy link
Contributor

evghen1 commented May 23, 2024

What problem are you facing?

Everytime provider requests magento client it creates new instance of RESTful client, what is not best on multiple invocations

How could Crossplane help solve your problem?

Cache in memory magento client after first creation and return it next time from cache.
@evghen1 evghen1 added the enhancement New feature or request label May 23, 2024
@evghen1
Copy link
Contributor Author

evghen1 commented May 30, 2024

@ca7alindev PR was not assigned to this issues, shall we close it already?

@ca7alindev
Copy link
Contributor

@evghen1 it should be closed by recently merged PR #9

@evghen1
Copy link
Contributor Author

evghen1 commented May 30, 2024

@ca7alindev it was not closed because PR was not attached to issue, please close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ca7alindev ca7alindev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evghen1 @ca7alindev