Implement reconciliation of category for create/update/delete categor… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca7alindev
force-pushed
the
4-base-controller-and-category-reconciliation
branch
from
49c5fe0
to
9034d4e
Compare
evghen1
requested changes
May 8, 2024
|
@ca7alindev any news? |
ca7alindev
force-pushed
the
4-base-controller-and-category-reconciliation
branch
from
9034d4e
to
fa09028
Compare
…ies using pure API calls, create controller that makes client connection using ProviderConfig credentials.
ca7alindev
force-pushed
the
4-base-controller-and-category-reconciliation
branch
from
fa09028
to
513b678
Compare
evghen1
requested changes
May 14, 2024
There was a problem hiding this comment.
@ca7alindev Rename file to simple apis/v1alpha1/category_types.go
Why we need category word twice here?
There was a problem hiding this comment.
@evghen1 in apis directory already exists v1alpha1 where are all magento provider level apis
…ries by id, added functions descriptions and error checks
evghen1
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.