Suppress HTTP error exceptions #234
Closed
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless explicitly overridden, the default behavior of the http client should be to suppress http errors. While it would make sense to make this not only default, but forced, there still may be use in development environments and debugging scenarios that may make sense to allow this to be a configurable option
Minishlink
reviewed
Jun 7, 2019
| @@ -44,7 +44,7 @@ public static function setUpBeforeClass() | |||
| */ | |||
| protected function setUp() | |||
| { | |||
| if (!(getenv('TRAVIS') || getenv('CI'))) { | |||
| if (getenv('TRAVIS') || getenv('CI')) { | |||
There was a problem hiding this comment.
Uh? No please don't skip the integration tests :o
There was a problem hiding this comment.
This one threw me off, maybe I'm misunderstanding though; the call to $this->markTestSkipped specifies "This test does not run on Travis". The conditional logic here shows that unless both getenv('TRAVIS') as well as getenv('CI') return false, skip the test. So I think, unless I'm just confusing myself at this point, I've just simplified the existing logic to the same effect? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless explicitly overridden, the default behavior of the HTTP client should be to suppress HTTP errors. While it would make sense to make this not only default, but forced, there still may be use cases in development environments and debugging scenarios that may make sense to allow this to be a configurable option.
directly fixes #197 and issues surrounding unusability due to erroneous, malicious, expired subscriptions.