WPT: Add form-based file upload coverage #8596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 6, 2017
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-811625
branch
from
e9e877b to
34a43be
Compare
Build PASSEDStarted: 2017-12-06 22:02:36 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-811625
branch
from
34a43be to
ca4636f
Compare
Tests multipart form POSTs with file inputs where the selected "file" was constructed using the `File` constructor and added to a `DataTransferItemList` (this avoids the user gesture requirement which otherwise would consign this to manual testing.) For the non-ASCII filenames with non-UTF-8 accept-charsets this also verifies fallback encoding/replacement of unrepresentable characters using numeric character references. whatwg/html#2861 Coverage for fallback encoding is still tentative because filename fallback encoding is not yet standardized. whatwg/html#3223 Bug: 661819 Change-Id: Ic646f76b0c8a0792d1214a7848d2238bcc3a76e7 Reviewed-on: https://chromium-review.googlesource.com/811625 Reviewed-by: Victor Costan <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Commit-Queue: Benjamin Wiley Sittler <[email protected]> Cr-Commit-Position: refs/heads/master@{#522197}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-811625
branch
from
ca4636f to
54c8915
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests multipart form POSTs with file inputs where the selected "file"
was constructed using the
Fileconstructor and added to aDataTransferItemList(this avoids the user gesture requirement whichotherwise would consign this to manual testing.) For the non-ASCII
filenames with non-UTF-8 accept-charsets this also verifies fallback
encoding/replacement of unrepresentable characters using numeric
character references. whatwg/html#2861
Coverage for fallback encoding is still tentative because filename
fallback encoding is not yet standardized.
whatwg/html#3223
Bug: 661819
Change-Id: Ic646f76b0c8a0792d1214a7848d2238bcc3a76e7
Reviewed-on: https://chromium-review.googlesource.com/811625
Reviewed-by: Victor Costan [email protected]
Reviewed-by: Joshua Bell [email protected]
Commit-Queue: Benjamin Wiley Sittler [email protected]
Cr-Commit-Position: refs/heads/master@{#522197}