From 2bc6950659a528cc4527d6a8f33eb2f15751c922 Mon Sep 17 00:00:00 2001 From: Traian Captan Date: Wed, 18 Jan 2023 11:47:37 -0800 Subject: [PATCH] Fix -webkit-image-set serialization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The '-webkit-' prefixed 'image-set' is expected to serialize to the same value as standard 'image-set'. https://drafts.csswg.org/css-images-4/#deprecated "Implementations must accept -webkit-image-set() as a parse-time alias of image-set(). (It’s a valid value, with identical arguments to image-set(), and is turned into image-set() during parsing.)" With this change Chrome will match the spec as well as Firefox and Safari. R=pdr Bug: 630597 Change-Id: I95fe2a10815afd8e3169299b0f33e688950c5ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167006 Reviewed-by: Philip Rogers Commit-Queue: Traian Captan Cr-Commit-Position: refs/heads/main@{#1094022} --- css/css-images/image-set/image-set-parsing.html | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/css/css-images/image-set/image-set-parsing.html b/css/css-images/image-set/image-set-parsing.html index b9b335a287b8a3..868861b8add32e 100644 --- a/css/css-images/image-set/image-set-parsing.html +++ b/css/css-images/image-set/image-set-parsing.html @@ -11,6 +11,13 @@ function test_valid_value_variants(property, value, serializedValue) { if (!serializedValue) serializedValue = value; test_valid_value(property, value, serializedValue); + + // The '-webkit-' prefixed 'image-set' is expected to serialize to the same + // value as standard 'image-set'. + // https://drafts.csswg.org/css-images-4/#deprecated + // "Implementations must accept -webkit-image-set() as a parse-time alias of + // image-set(). (It’s a valid value, with identical arguments to image-set(), + // and is turned into image-set() during parsing.)" test_valid_value(property, "-webkit-" + value, serializedValue); }