-
Notifications
You must be signed in to change notification settings - Fork 83
/
update.go
364 lines (331 loc) · 10.9 KB
/
update.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
// Copyright 2018 The WPT Dashboard Project. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package checks
import (
"context"
"fmt"
"net/http"
"sort"
"strings"
"time"
mapset "github.com/deckarep/golang-set"
"github.com/gorilla/mux"
"github.com/web-platform-tests/wpt.fyi/api/checks/summaries"
"github.com/web-platform-tests/wpt.fyi/shared"
)
// CheckProcessingQueue is the name of the TaskQueue that handles processing and
// interpretation of TestRun results, in order to update the GitHub checks.
const CheckProcessingQueue = "check-processing"
const failChecksOnRegressionFeature = "failChecksOnRegression"
const onlyChangesAsRegressionsFeature = "onlyChangesAsRegressions"
// updateCheckHandler handles /api/checks/[commit] POST requests.
func updateCheckHandler(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
log := shared.GetLogger(ctx)
vars := mux.Vars(r)
sha, err := shared.ParseSHA(vars["commit"])
if err != nil {
log.Warningf(err.Error())
http.Error(w, err.Error(), http.StatusBadRequest)
return
}
if err := r.ParseForm(); err != nil {
log.Warningf("Failed to parse form: %s", err.Error())
http.Error(w, err.Error(), http.StatusBadRequest)
return
}
filter, err := shared.ParseTestRunFilterParams(r.Form)
if err != nil {
log.Warningf("Failed to parse params: %s", err.Error())
http.Error(w, err.Error(), http.StatusBadRequest)
return
}
if len(filter.Products) != 1 {
msg := "product param is missing"
log.Warningf(msg)
http.Error(w, msg, http.StatusBadRequest)
return
}
filter.SHAs = shared.SHAs{sha}
headRun, baseRun, err := loadRunsToCompare(ctx, filter)
if err != nil {
msg := "Could not find runs to compare: " + err.Error()
log.Errorf(msg)
http.Error(w, msg, http.StatusNotFound)
return
}
sha = headRun.FullRevisionHash
aeAPI := shared.NewAppEngineAPI(ctx)
diffAPI := shared.NewDiffAPI(ctx)
suites, err := NewAPI(ctx).GetSuitesForSHA(sha)
if err != nil {
log.Warningf("Failed to load CheckSuites for %s: %s", sha, err.Error())
http.Error(w, err.Error(), http.StatusInternalServerError)
return
} else if len(suites) < 1 {
log.Debugf("No CheckSuites found for %s", sha)
}
updatedAny := false
for _, suite := range suites {
summaryData, err := getDiffSummary(aeAPI, diffAPI, suite, *baseRun, *headRun)
if err == shared.ErrRunNotInSearchCache {
http.Error(w, err.Error(), http.StatusUnprocessableEntity)
return
} else if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
updated, updateErr := updateCheckRunSummary(ctx, summaryData, suite)
if updateErr != nil {
err = updateErr
}
updatedAny = updatedAny || updated
}
if err != nil {
log.Errorf("Failed to update check_run(s): %s", err.Error())
http.Error(w, err.Error(), http.StatusInternalServerError)
} else if updatedAny {
w.Write([]byte("Check(s) updated"))
} else {
w.Write([]byte("No check(s) updated"))
}
}
func loadRunsToCompare(ctx context.Context, filter shared.TestRunFilter) (headRun, baseRun *shared.TestRun, err error) {
one := 1
store := shared.NewAppEngineDatastore(ctx, false)
runs, err := store.TestRunQuery().LoadTestRuns(filter.Products, filter.Labels, filter.SHAs, filter.From, filter.To, &one, nil)
if err != nil {
return nil, nil, err
}
run := runs.First()
if run == nil {
return nil, nil, fmt.Errorf("no test run found for %s @ %s",
filter.Products[0].String(),
shared.CropString(filter.SHAs.FirstOrLatest(), 7))
}
labels := run.LabelsSet()
if labels.Contains(shared.MasterLabel) {
headRun = run
baseRun, err = loadMasterRunBefore(ctx, filter, headRun)
} else if labels.Contains(shared.PRBaseLabel) {
baseRun = run
headRun, err = loadPRRun(ctx, filter, shared.PRHeadLabel)
} else if labels.Contains(shared.PRHeadLabel) {
headRun = run
baseRun, err = loadPRRun(ctx, filter, shared.PRBaseLabel)
} else {
return nil, nil, fmt.Errorf("test run %d doesn't have pr_base, pr_head or master label", run.ID)
}
return headRun, baseRun, err
}
func loadPRRun(ctx context.Context, filter shared.TestRunFilter, extraLabel string) (*shared.TestRun, error) {
// Find the corresponding pr_base or pr_head run.
one := 1
store := shared.NewAppEngineDatastore(ctx, false)
labels := mapset.NewSetWith(extraLabel)
runs, err := store.TestRunQuery().LoadTestRuns(filter.Products, labels, filter.SHAs, nil, nil, &one, nil)
run := runs.First()
if err != nil {
return nil, err
}
if run == nil {
err = fmt.Errorf("no test run found for %s @ %s with label %s",
filter.Products[0].String(), filter.SHAs.FirstOrLatest(), extraLabel)
}
return run, err
}
func loadMasterRunBefore(ctx context.Context, filter shared.TestRunFilter, headRun *shared.TestRun) (*shared.TestRun, error) {
// Get the most recent, but still earlier, master run to compare.
store := shared.NewAppEngineDatastore(ctx, false)
one := 1
to := headRun.TimeStart.Add(-time.Millisecond)
labels := mapset.NewSetWith(headRun.Channel(), shared.MasterLabel)
runs, err := store.TestRunQuery().LoadTestRuns(filter.Products, labels, nil, nil, &to, &one, nil)
baseRun := runs.First()
if err != nil {
return nil, err
}
if baseRun == nil {
err = fmt.Errorf("no master run found for %s before %s",
filter.Products[0].String(), filter.SHAs.FirstOrLatest())
}
return baseRun, err
}
func getDiffSummary(aeAPI shared.AppEngineAPI, diffAPI shared.DiffAPI, suite shared.CheckSuite, baseRun, headRun shared.TestRun) (summaries.Summary, error) {
diffFilter := shared.DiffFilterParam{Added: true, Changed: true, Deleted: true}
diff, err := diffAPI.GetRunsDiff(baseRun, headRun, diffFilter, nil)
if err != nil {
return nil, err
}
checkProduct := shared.ProductSpec{
// [browser]@[sha] is plenty specific, and avoids bad version strings.
ProductAtRevision: shared.ProductAtRevision{
Product: shared.Product{BrowserName: headRun.BrowserName},
Revision: headRun.Revision,
},
Labels: mapset.NewSetWith(baseRun.Channel()),
}
diffURL := diffAPI.GetDiffURL(baseRun, headRun, &diffFilter)
host := aeAPI.GetHostname()
checkState := summaries.CheckState{
HostName: host,
TestRun: &headRun,
Product: checkProduct,
HeadSHA: headRun.FullRevisionHash,
DetailsURL: diffURL,
Status: "completed",
PRNumbers: suite.PRNumbers,
}
var regressions mapset.Set
if aeAPI.IsFeatureEnabled("onlyChangesAsRegressions") {
regressionFilter := shared.DiffFilterParam{Changed: true} // Only changed items
changeOnlyDiff, err := diffAPI.GetRunsDiff(baseRun, headRun, regressionFilter, nil)
if err != nil {
return nil, err
}
regressions = changeOnlyDiff.Differences.Regressions()
} else {
regressions = diff.Differences.Regressions()
}
hasRegressions := regressions.Cardinality() > 0
neutral := "neutral"
checkState.Conclusion = &neutral
checksCanBeNonNeutral := aeAPI.IsFeatureEnabled(failChecksOnRegressionFeature)
// Set URL path to deepest shared dir.
var tests []string
if hasRegressions {
tests = shared.ToStringSlice(regressions)
} else {
tests, _ = shared.MapStringKeys(diff.AfterSummary)
}
sharedPath := "/results" + shared.GetSharedPath(tests...)
diffURL.Path = sharedPath
var summary summaries.Summary
resultsComparison := summaries.ResultsComparison{
BaseRun: baseRun,
HeadRun: headRun,
HostURL: fmt.Sprintf("https://%s/", host),
DiffURL: diffURL.String(),
}
if headRun.LabelsSet().Contains(shared.PRHeadLabel) {
// Deletions are meaningless and abundant comparing to master; ignore them.
masterDiffFilter := shared.DiffFilterParam{Added: true, Changed: true, Unchanged: true}
masterDiffURL := diffAPI.GetMasterDiffURL(headRun, &masterDiffFilter)
masterDiffURL.Path = sharedPath
resultsComparison.MasterDiffURL = masterDiffURL.String()
}
if !hasRegressions {
collapsed := collapseSummary(diff, 10)
data := summaries.Completed{
CheckState: checkState,
ResultsComparison: resultsComparison,
Results: make(summaries.BeforeAndAfter),
}
tests, _ := shared.MapStringKeys(collapsed)
sort.Strings(tests)
for _, test := range tests {
if len(data.Results) < 10 {
data.Results[test] = collapsed[test]
} else {
data.More++
}
}
success := "success"
data.CheckState.Conclusion = &success
summary = data
} else {
data := summaries.Regressed{
CheckState: checkState,
ResultsComparison: resultsComparison,
Regressions: make(summaries.BeforeAndAfter),
}
tests := shared.ToStringSlice(regressions)
sort.Strings(tests)
for _, path := range tests {
if len(data.Regressions) <= 10 {
data.Regressions.Add(path, diff.BeforeSummary[path], diff.AfterSummary[path])
} else {
data.More++
}
}
if checksCanBeNonNeutral {
actionRequired := "action_required"
data.CheckState.Conclusion = &actionRequired
}
summary = data
}
return summary, nil
}
type pathKeys []string
func (e pathKeys) Len() int { return len(e) }
func (e pathKeys) Swap(i, j int) { e[i], e[j] = e[j], e[i] }
func (e pathKeys) Less(i, j int) bool {
return len(strings.Split(e[i], "/")) > len(strings.Split(e[j], "/"))
}
// collapseDiff collapses a tree of file paths into a smaller tree of folders.
func collapseDiff(diff shared.ResultsDiff, limit int) shared.ResultsDiff {
keys, _ := shared.MapStringKeys(diff)
paths := shared.ToStringSlice(collapsePaths(keys, limit))
result := make(shared.ResultsDiff)
for k, v := range diff {
for _, p := range paths {
if strings.HasPrefix(k, p) {
result.Add(p, v)
break
}
}
}
return result
}
// collapseSummary collapses a tree of file paths into a smaller tree of folders.
func collapseSummary(diff shared.RunDiff, limit int) summaries.BeforeAndAfter {
beforeKeys, _ := shared.MapStringKeys(diff.BeforeSummary)
afterKeys, _ := shared.MapStringKeys(diff.AfterSummary)
keys := shared.ToStringSlice(
shared.NewSetFromStringSlice(beforeKeys).Union(shared.NewSetFromStringSlice(afterKeys)),
)
paths := shared.ToStringSlice(collapsePaths(keys, limit))
result := make(summaries.BeforeAndAfter)
for _, k := range keys {
for _, p := range paths {
if strings.HasPrefix(k, p) {
result.Add(p, diff.BeforeSummary[k], diff.AfterSummary[k])
break
}
}
}
return result
}
func collapsePaths(keys []string, limit int) mapset.Set {
result := shared.NewSetFromStringSlice(keys)
// 10 iterations to avoid edge-case infinite looping risk.
for i := 0; i < 10 && result.Cardinality() > limit; i++ {
sort.Sort(pathKeys(keys))
collapsed := mapset.NewSet()
depth := -1
for _, k := range keys {
// Something might have already collapsed down 1 dir into this one.
if collapsed.Contains(k) {
continue
}
parts := strings.Split(k, "/")
if parts[len(parts)-1] == "" {
parts = parts[:len(parts)-1]
}
if len(parts) < depth {
collapsed.Add(k)
continue
}
path := strings.Join(parts[:len(parts)-1], "/") + "/"
collapsed.Add(path)
depth = len(parts)
}
if i > 0 && depth < 3 {
break
}
keys = shared.ToStringSlice(collapsed)
result = collapsed
}
return result
}