fix(isProfaneLike): abort trying to match every instance of profane words.

This has caused several issues should be up to the implementer to augment the list for their
specific use-case. From this point on, only exact (case-insensitive) matches will be filtered.

RocketChat/Rocket.Chat#9880,
#33, #25,
#29

Author: web-mech

lib/badwords.js

@@ -39,15 +39,20 @@ var Filter = (function() {
    * @param {string} word - String to evaluate for profanity.
    */
   Filter.prototype.isProfaneLike = function profaneLike(word) {
-    return !!~this.exclude.indexOf(word) ? false : !!~this.list.indexOf(word) || this.list
+    if (!!~this.exclude.indexOf(word)) {
+      return false;
+    }
+
+    if (!!~this.list.indexOf(word)) {
+      return true;
+    }
+
+    return this.list
       .map(function(w) {
-        return new RegExp(w.replace(/(\W)/g, '\\$1'), 'gi');
+        return new RegExp('^' + w.replace(/(\W)/g, '\\$1') + '$', 'gi');
       }, this)
       .reduce(function(outcome, wordExp) {
-        if (wordExp.test(word)) {
-          return true;
-        }
-        return outcome;
+        return outcome || wordExp.test(word);
       }, false);
   };
 

test/filter.js

@@ -6,7 +6,9 @@ var Filter = require('../lib/badwords.js'),
 describe('filter', function(){
 	describe('clean',function(){
 		it('Should replace a bad word within a sentence asterisks (******)',function(){
+			console.log(filter.clean('Don\'t be an ash0le'));
 			assert(filter.clean('Don\'t be an ash0le') === 'Don\'t be an ******');
+
 		});
 
 		it('Should replace multiple instances of any bad words within a sentence asterisks (******)',function(){
@@ -34,8 +36,12 @@ describe('filter', function(){
 			assert(filter.clean('<p>Don\'t be an asshole</p>') === '<p>Don\'t be an *******</p>');
 		});
 
-		it('Should filter words that are derivatives of words from the filter blacklist', function() {
+		xit('Should filter words that are derivatives of words from the filter blacklist', function() {
 			assert(filter.clean('shitshit') === '********');
     });
+
+    it('Shouldn\'t filter words that aren\'t profane.', function() {
+			assert(filter.clean('hello there') === 'hello there');
+    });
 	});
 });