-
-
Notifications
You must be signed in to change notification settings - Fork 733
fix: update event handling to support batch processing of FsEvents #11460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the event handling system to support batch processing of file system events instead of processing them individually. The change modifies the channel communication to send vectors of FsEvent rather than single events.
- Changes event channels from
UnboundedSender<FsEvent>toUnboundedSender<Vec<FsEvent>> - Updates event processing logic to handle batched events
- Modifies test assertions to work with the new batched event structure
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/rspack_fs/src/watcher/trigger.rs | Updates trigger to send batched events and refactors event processing logic |
| crates/rspack_fs/src/watcher/scanner.rs | Modifies scanner to send single events wrapped in vectors for consistency |
| crates/rspack_fs/src/watcher/executor.rs | Updates executor to receive and process batched events |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
📦 Binary Size-limit
❌ Size increased by 768bytes from 47.60MB to 47.61MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #11460 will not alter performanceComparing 🎉 Hooray!
|
d2d6e4b to
9492318
Compare
Summary
This PR refactors the file system event handling architecture to support batch processing of FsEvents.
The batch event will so fast consume if user setting watchOptions.aggregateTimeout as zero.
We should batch processing associated_event by trigger finding. Otherwise it will trigger twice callback.
Related links
Checklist