diff --git a/crates/node_binding/src/resolver.rs b/crates/node_binding/src/resolver.rs index 8bfab897fc34..942ca01e7e09 100644 --- a/crates/node_binding/src/resolver.rs +++ b/crates/node_binding/src/resolver.rs @@ -80,7 +80,10 @@ impl JsResolver { Either::::A(ResourceData::from(resource).into()), ), Ok(rspack_core::ResolveResult::Ignored) => Ok(Either::B(false)), - Err(err) => Err(napi::Error::from_reason(format!("{err:?}"))), + Err(err) => Err(napi::Error::new( + ErrorCode::Napi(napi::Status::GenericFailure), + format!("{err:?}"), + )), } }, || {}, diff --git a/crates/node_binding/src/utils.rs b/crates/node_binding/src/utils.rs index cf70853a6d01..8739bdb752af 100644 --- a/crates/node_binding/src/utils.rs +++ b/crates/node_binding/src/utils.rs @@ -12,12 +12,13 @@ pub fn callbackify( ) -> Result<(), ErrorCode> where R: 'static + ToNapiValue, - F: 'static + Send + Future>, + F: 'static + Send + Future>, { let mut call_js_back = Some(Box::new(call_js_back)); let tsfn = f .build_threadsafe_function::() + .error_status::() .callee_handled::() .max_queue_size::<1>() .weak::()