-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should pass runtimeTemplate to TemplateContext
#5013
Comments
@LingyuCoder would you mind having a look? |
Rspack currently does not support any environment configuration options, so these es6+ checks in runtimeTemplate can be directly treated as false. Moreover, all current runtimeModules are implemented using static es5 code. If aligning whole runtimeTemplate with Webpack will cost lots of work. |
Alright, we can align with webpack when we have manpower. |
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
I've just stumbled upon this issue coming from #5316 so I think it's still a valid ask Any reason to not just use ES5 syntax for everyone anyway? People that need <ES5 can keep using Webpack, surely? |
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
This issue is duplicated with #5136, so I will close this issue and just discuss there. |
What problem does this feature solve?
here are some examples: https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/dependencies/HarmonyExportImportedSpecifierDependency.js#L938-L947
https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/dependencies/HarmonyExportImportedSpecifierDependency.js#L1104-L1106
reference
https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/RuntimeTemplate.js#L1-L1060
What does the proposed API of configuration look like?
same as webpack
The text was updated successfully, but these errors were encountered: