Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pass runtimeTemplate to TemplateContext #5013

Closed
IWANABETHATGUY opened this issue Dec 14, 2023 · 7 comments
Closed

Should pass runtimeTemplate to TemplateContext #5013

IWANABETHATGUY opened this issue Dec 14, 2023 · 7 comments
Assignees
Labels
feat New feature or request stale team The issue/pr is created by the member of Rspack.

Comments

@IWANABETHATGUY IWANABETHATGUY added feat New feature or request pending triage The issue/PR is currently untouched. labels Dec 14, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 14, 2023
@IWANABETHATGUY
Copy link
Contributor Author

@LingyuCoder would you mind having a look?

@LingyuCoder
Copy link
Collaborator

LingyuCoder commented Dec 14, 2023

@LingyuCoder would you mind having a look?

Rspack currently does not support any environment configuration options, so these es6+ checks in runtimeTemplate can be directly treated as false.

Moreover, all current runtimeModules are implemented using static es5 code. If aligning whole runtimeTemplate with Webpack will cost lots of work.

@LingyuCoder LingyuCoder self-assigned this Dec 14, 2023
@IWANABETHATGUY
Copy link
Contributor Author

Alright, we can align with webpack when we have manpower.

@jerrykingxyz jerrykingxyz removed the pending triage The issue/PR is currently untouched. label Dec 25, 2023
Copy link

stale bot commented Feb 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Feb 23, 2024
@alfaproject
Copy link

I've just stumbled upon this issue coming from #5316 so I think it's still a valid ask

Any reason to not just use ES5 syntax for everyone anyway? People that need <ES5 can keep using Webpack, surely?

@stale stale bot removed the stale label Apr 14, 2024
Copy link

stale bot commented Jun 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jun 13, 2024
@LingyuCoder
Copy link
Collaborator

This issue is duplicated with #5136, so I will close this issue and just discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

4 participants