fix: should not throw minify error when using import.meta in iife output #1125
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a minification error that occurs when using import.meta in IIFE (Immediately Invoked Function Expression) output format. The fix involves configuring the minifier to properly handle ES modules syntax by setting the module: true option in the minifier configuration.
- Adds
module: trueto the minifier configuration to handle ES modules syntax correctly - Updates test files to include
import.meta.dirnameusage to verify the fix - Ensures IIFE output can properly handle
import.metawithout throwing minification errors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/config.ts | Adds minifier configuration with module: true to handle ES modules syntax |
| tests/integration/iife/src/utils.ts | Updates function to use import.meta.dirname for testing the fix |
| tests/integration/iife/index.test.ts | Updates test expectation to include the new import.meta usage |
fi3ework
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should not throw minify error when using import.meta in iife output
Related Links
Checklist