Skip to content

chore: resolve OutputFileSystem type TODO #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Dec 31, 2024
Merged

chore: resolve OutputFileSystem type TODO #4304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7445a22
chore: resolve OutputFileSystem type TODO
chenjiahan Dec 31, 2024
26327ab
Merge branch 'main' into resolve_todo_1231
chenjiahan Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions packages/core/src/server/devServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ import {
getTransformedHtml,
loadBundle,
} from './environment';
import {
type RsbuildDevMiddlewareOptions,
getMiddlewares,
} from './getDevMiddlewares';
import { type CompileMiddlewareAPI, getMiddlewares } from './getDevMiddlewares';
import {
type StartServerResult,
getAddressUrls,
Expand Down Expand Up @@ -128,8 +125,7 @@ export async function createDevServer<
https,
};

// TODO: remove this type assertion after Rspack fix the type definition
let outputFileSystem = fs as Rspack.OutputFileSystem;
let outputFileSystem: Rspack.OutputFileSystem = fs;
let lastStats: Rspack.Stats[];

// should register onDevCompileDone hook before startCompile
Expand All @@ -148,9 +144,7 @@ export async function createDevServer<
})
: Promise.resolve();

const startCompile: () => Promise<
RsbuildDevMiddlewareOptions['compileMiddlewareAPI']
> = async () => {
const startCompile: () => Promise<CompileMiddlewareAPI> = async () => {
const compiler = customCompiler || (await createCompiler());

if (!compiler) {
Expand All @@ -172,11 +166,10 @@ export async function createDevServer<

await compilerDevMiddleware.init();

// TODO: remove this type assertion after Rspack fix the type definition
outputFileSystem =
(isMultiCompiler(compiler)
? compiler.compilers[0].outputFileSystem
: compiler.outputFileSystem) || (fs as Rspack.OutputFileSystem);
: compiler.outputFileSystem) || fs;

return {
middleware: compilerDevMiddleware.middleware,
Expand Down
Loading