Skip to content

Stimulus - pass the error from response if available in webauthn:attestation:failure event #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FluffyDiscord opened this issue Jan 7, 2025 · 2 comments · Fixed by #675
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FluffyDiscord
Copy link

Description

We get error message from backend if signup fails for any reason and we can listen to the webauthn:attestation:failure event that Stimulus controller dispatches.

The issue is, that we don't have any details in this event, no response message, or status code, or error message, so we cannot tell the user what is wrong, except showing a generic error message.

Example

No response

@Spomky Spomky self-assigned this Jan 8, 2025
@Spomky Spomky added the enhancement New feature or request label Jan 8, 2025
@Spomky Spomky added this to the 5.1.0 milestone Jan 8, 2025
@Spomky
Copy link
Contributor

Spomky commented Jan 8, 2025

Indeed, this event is missing details.

@Spomky Spomky linked a pull request Jan 18, 2025 that will close this issue
4 tasks
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants