Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the "get_element_in_viewport_ratio" calculation #178

Open
viswavi opened this issue Sep 18, 2024 · 0 comments
Open

Bug in the "get_element_in_viewport_ratio" calculation #178

viswavi opened this issue Sep 18, 2024 · 0 comments

Comments

@viswavi
Copy link

viswavi commented Sep 18, 2024

https://github.com/web-arena-x/webarena/blame/1469b7c9d8eaec3177855b3131569751f43a40d6/browser_env/processors.py#L171

This should say

ratio = overlap_width * overlap_height / (width * height)

No?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant