Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about this json schema link #226

Closed
kingdonb opened this issue Mar 11, 2022 · 2 comments
Closed

Question about this json schema link #226

kingdonb opened this issue Mar 11, 2022 · 2 comments

Comments

@kingdonb
Copy link
Collaborator

Expected behaviour

I was unclear about the goal of linking to the JSON schema, or if the link is working as intended:
Screen Shot 2022-03-11 at 4 06 13 PM

(right above the cursor, click it to go to...)

Screen Shot 2022-03-11 at 4 07 40 PM

Is this our link-widget, and is it meant to retrieve and load the actual JSON Schema in an editor pane?

Actual behaviour

The JSON schema was loaded in the editor window, it was unclear how directly this behavior benefits the user.

Steps to reproduce

Connect to a cluster that has a CRD installed and open a file with an instance of that CRD (like HelmRelease) – click the link at the top of the editor frame.

Versions

kubectl version: v1.23.4
Flux version: v0.27.3
Git version: 2.35.1
Azure version: N/A
Extension version: 0.19.0
VSCode version: 1.64.2 (Universal)
Operating System (OS) and its version: MacOS 12.2.1

@usernamehw
Copy link
Collaborator

usernamehw commented Mar 12, 2022

It is a feature of the YAML extension: redhat-developer/yaml-language-server#424
YAML extension creates CodeLens header for all yaml files that have json-schema associated with it.
json-schema provides autocomplete/hover/validation information.

@kingdonb
Copy link
Collaborator Author

Alright, then this is nothing to do with our extension. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants