From 8df8b8be5180e657c79e3cd38b96a7ca7924ff37 Mon Sep 17 00:00:00 2001 From: Chance Zibolski Date: Wed, 4 Nov 2020 18:24:57 -0800 Subject: [PATCH] tracing: Allow specifying JAEGER_ENDPOINT instead of sampling server or local agent port closes #203 --- tracing/tracing.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tracing/tracing.go b/tracing/tracing.go index ae38417e..2d1c6901 100644 --- a/tracing/tracing.go +++ b/tracing/tracing.go @@ -10,7 +10,7 @@ import ( // ErrInvalidConfiguration is an error to notify client to provide valid trace report agent or config server var ( - ErrBlankTraceConfiguration = errors.New("no trace report agent or config server specified") + ErrBlankTraceConfiguration = errors.New("no trace report agent, config server, or collector endpoint specified") ) // installJaeger registers Jaeger as the OpenTracing implementation. @@ -35,7 +35,7 @@ func NewFromEnv(serviceName string) (io.Closer, error) { return nil, errors.Wrap(err, "could not load jaeger tracer configuration") } - if cfg.Sampler.SamplingServerURL == "" && cfg.Reporter.LocalAgentHostPort == "" { + if cfg.Sampler.SamplingServerURL == "" && cfg.Reporter.LocalAgentHostPort == "" && cfg.Reporter.CollectorEndpoint == "" { return nil, ErrBlankTraceConfiguration }