Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isCurrent method is buggy with https #6

Open
dator-zz opened this issue Oct 3, 2011 · 1 comment
Open

isCurrent method is buggy with https #6

dator-zz opened this issue Oct 3, 2011 · 1 comment

Comments

@dator-zz
Copy link

dator-zz commented Oct 3, 2011

Hi :)

I have my domain in https and since i put the ssl, the isCurrent method of ioMenuItem seems buggy.

In the code you have

$url = $this->getCurrentUri();
$menuUrl = $this->getUri(array('absolute' => true));

In my context :

$menuUrl = "http://domain.com/ad"
and $url = "http://domain.com:443/ad"

When the isCurrent method do the comparison, $menuUrl and $url are not equal.

Do you have an idea how to fix that ? :)

Thanks a lot !

@weaverryan
Copy link
Owner

Hey Clément!

So, the "is current" functionality for this plugin is basically "good" but not perfect. So, if it's not working for you (and this looks legit), my recommendation would be to subclass ioMenuItem and override getCurrentUri, Inside your method, you can normalize however you need - add the port etc.

This is probably the best way to go - you'll have full control of your situation. Let me know if that works!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants